Skip to content

fix: stop the Deploy to Cloudflare form asking for the TinaCloud keys - #364

Merged
joshbermanssw merged 3 commits into
mainfrom
jb/cloudflare-no-secrets-prompt
Nov 20, 2026
Merged

joshbermanssw merged 3 commits into
mainfrom
jb/cloudflare-no-secrets-prompt

Conversation

@joshbermanssw

Copy link
Copy Markdown
Member

cc: none
Related PBI: https://github.com/tinacms/tinacloud/pull/4596

Summary

The Deploy to Cloudflare form marks NEXT_PUBLIC_TINA_CLIENT_ID and TINA_TOKEN as required ("Please fill in this field."), but TinaCloud's flow tells people to skip them because it adds the keys as build variables after the deploy. This comments them out of .dev.vars.example and drops the cloudflare.bindings block, the same way tina-nextjs-starter already avoids the prompt.

Evidence

  • Cloudflare's docs list only description for cloudflare.bindings and don't document an optional flag, so removing the variables is the only documented way to drop the field.
  • Not yet tested on a real Deploy button run: the form should show no fields once this is on main. Until it merges, the button reads main of this repo, so it can't be tried from this branch.

Merge Danger

Door: two-way
Blast Radius: deploy-button

If Cloudflare still prompts for something else, the first build fails with the existing "Missing build variable(s)" message until the keys are set, as it does today.

Changes made by Claude Sonnet 5.5 via Claude Code.

TinaCloud adds them as build variables after the deploy, and Cloudflare marks every listed secret required, so the form could not be skipped.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
tina-docs Ready Ready Preview Nov 20, 2026 1:07am UTC

Request Review

harley-j
harley-j previously approved these changes Nov 20, 2026

@harley-j harley-j left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshbermanssw
joshbermanssw marked this pull request as ready for review November 20, 2026 00:52
@joshbermanssw
joshbermanssw enabled auto-merge (squash) November 20, 2026 00:52
The step has no per-attempt cap, so one stalled apt run used up its whole 6 minute timeout and failed the search job. Cap each attempt and retry, as the browser install step already does.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The stall was the runner's apt mirror and passed on a re-run, so it doesn't belong in this PR.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@joshbermanssw
joshbermanssw merged commit bdc4d71 into main Nov 20, 2026
7 checks passed
@joshbermanssw
joshbermanssw deleted the jb/cloudflare-no-secrets-prompt branch November 20, 2026 01:45

This branch was successfully deployed

1 active deployment
Preview — 97e22d30 Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants