Repository navigation
fix: stop the Deploy to Cloudflare form asking for the TinaCloud keys - #364
Merged
Merged
Conversation
TinaCloud adds them as build variables after the deploy, and Cloudflare marks every listed secret required, so the form could not be skipped. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
joshbermanssw
marked this pull request as ready for review
November 20, 2026 00:52
joshbermanssw
enabled auto-merge (squash)
November 20, 2026 00:52
joshbermanssw
disabled auto-merge
November 20, 2026 00:57
The step has no per-attempt cap, so one stalled apt run used up its whole 6 minute timeout and failed the search job. Cap each attempt and retry, as the browser install step already does. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The stall was the runner's apt mirror and passed on a re-run, so it doesn't belong in this PR. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
joshbermanssw
enabled auto-merge (squash)
November 20, 2026 01:08
harley-j
approved these changes
Nov 20, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc: none
Related PBI: https://github.com/tinacms/tinacloud/pull/4596
Summary
The Deploy to Cloudflare form marks
NEXT_PUBLIC_TINA_CLIENT_IDandTINA_TOKENas required ("Please fill in this field."), but TinaCloud's flow tells people to skip them because it adds the keys as build variables after the deploy. This comments them out of.dev.vars.exampleand drops thecloudflare.bindingsblock, the same waytina-nextjs-starteralready avoids the prompt.Evidence
descriptionforcloudflare.bindingsand don't document an optional flag, so removing the variables is the only documented way to drop the field.main. Until it merges, the button readsmainof this repo, so it can't be tried from this branch.Merge Danger
Door: two-way
Blast Radius: deploy-button
If Cloudflare still prompts for something else, the first build fails with the existing "Missing build variable(s)" message until the keys are set, as it does today.
Changes made by Claude Sonnet 5.5 via Claude Code.